PE: Fix import parser for non-well-formed import table #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4b
approved these changes
Nov 14, 2024
|
NB backwards compatible with 0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelists:
ImportDirectoryEntry::is_nullImportDirectoryEntry::is_possibly_validto filter out invalid entries wherename_rvaandimport_address_table_rvaare both zero. Those never be zero by design if the entry is valid.The change is straightforward, it does as well as how Windows Loader does. Parser should stop if it is not
is_possibly_validis the same behaviour with Windows Loader and should be more safe than before. This is special exception for non-well-formed case and should not affect well-formed binaries at all.The same behaviour can be found at systeminformer (formely processhacker) implementation (respectively, peview):
https://github.com/winsiderss/systeminformer/blob/82c625783a035fa7eac355783f527bb53fb1a384/phlib/mapldr.c#L1635
This PR is backward compatible; thus minor changes.